Messages in this thread Patch in this message | | | Date | Wed, 2 Mar 2011 08:40:47 GMT | From | tip-bot for Arnaldo Carvalho de Melo <> | Subject | [tip:perf/core] perf top browser: Handle empty active symbols list |
| |
Commit-ID: 3166fc8fb6a2f52273d545e970297524e02c3e39 Gitweb: http://git.kernel.org/tip/3166fc8fb6a2f52273d545e970297524e02c3e39 Author: Arnaldo Carvalho de Melo <acme@redhat.com> AuthorDate: Tue, 1 Mar 2011 10:21:44 -0300 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Tue, 1 Mar 2011 10:21:44 -0300
perf top browser: Handle empty active symbols list
Fixing a SEGV. An empty list could happen when not being able to resolve symbols, for instance when --vmlinux invalid-file is used.
Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Mike Galbraith <efault@gmx.de> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Cc: Tom Zanussi <tzanussi@gmail.com> LKML-Reference: <new-submission> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/ui/browsers/top.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/tools/perf/util/ui/browsers/top.c b/tools/perf/util/ui/browsers/top.c index e9381ec..5a06538 100644 --- a/tools/perf/util/ui/browsers/top.c +++ b/tools/perf/util/ui/browsers/top.c @@ -76,6 +76,12 @@ static void perf_top_browser__update_rb_tree(struct perf_top_browser *browser) browser->root = RB_ROOT; browser->b.top = NULL; browser->sum_ksamples = perf_top__decay_samples(top, &browser->root); + /* + * No active symbols + */ + if (top->rb_entries == 0) + return; + perf_top__find_widths(top, &browser->root, &browser->dso_width, &browser->dso_short_width, &browser->sym_width);
| |