lkml.org 
[lkml]   [2011]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch] Fix bug #13853: dereference pointer 'dev' before null check
    This patch fixes bug #13853 .This still exists in latest version.
    'dev' is dereferenced before testing for NULL.

    Signed-off-by: Jinqiu Yang<crindy646@gmail.com>
    --- a/drivers/net/ariadne.c
    +++ b/drivers/net/ariadne.c
    @@ -420,7 +420,7 @@ static inline void ariadne_reset(struct
    static irqreturn_t ariadne_interrupt(int irq, void *data)
    {
    struct net_device *dev = (struct net_device *) data;
    - volatile struct Am79C960 *lance = (struct Am79C960*)dev->base_addr;
    + volatile struct Am79C960 *lance;
    struct ariadne_private *priv;
    int csr0, boguscnt;
    int handled = 0;
    @@ -429,6 +429, 7 @@ static irqreturn_t ariadne_interrupt(int
    printk(KERN_WARNING "ariadne_interrupt(): irq for unknown device.\n");
    return IRQ_NONE;
    }
    + lance = (struct Am79C960 *)dev->base_addr;

    lance->RAP = CSR0; /* PCnet-ISA Controller Status */





    \
     
     \ /
      Last update: 2011-03-03 03:23    [W:0.033 / U:29.984 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site