lkml.org 
[lkml]   [2011]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm/dmapool.c: Do not create/destroy sysfs file while holding pools_lock
On Tue, Mar 01, 2011 at 08:35:53PM -0800, Eric W. Biederman wrote:
> Andrew Morton <akpm@linux-foundation.org> writes:
> > One way of fixing this would be to create another singleton lock:
> >
> >
> > {
> > static DEFINE_MUTEX(pools_sysfs_lock);
> > static bool pools_sysfs_done;
> >
> > mutex_lock(&pools_sysfs_lock);
> > if (pools_sysfs_done == false) {
> > create_sysfs_stuff();
> > pools_sysfs_done = true;
> > }
> > mutex_unlock(&pools_sysfs_lock);
> > }
> >
> > That's not terribly pretty.
>
> Or possibly use module_init style magic. Where use module
> initialization and remove to trigger creation and deletion of the sysfs.
>

I'm not following how module initialization can help here. Are you suggesting
that all devices get a 'pools' attribute regardless of whether any dma pools
are actually created?

Shaun


\
 
 \ /
  Last update: 2011-03-02 06:25    [W:0.046 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site