Messages in this thread | | | Date | Wed, 2 Mar 2011 22:28:51 +0000 | From | Mark Brown <> | Subject | Re: [Qualcomm PM8921 MFD 1/6] mfd: pm8921: Add PMIC 8921 core driver |
| |
On Wed, Mar 02, 2011 at 02:13:16PM -0800, adharmap@codeaurora.org wrote:
> +config MFD_PM8XXX > + tristate "Support for Qualcomm PM8xxx subdevices" > + help > + This option enables the usage of various Qualcomm PMIC 8xxx subdevice > + drivers. This is required in order to use generic PM8xxx subdevice > + drivers. Selecting with option will result in PM8xxx subdevice > + drivers being compiled by default.
As this is selected by the driver it shouldn't have any help text - there's no point in users seeing the option since it's useless by itself. If we get enough to make an option useful either a menu or dependencies from the individual MFDs would be a better option.
> +static int __devinit pm8921_add_subdevices(const struct pm8921_platform_data > + *pdata, > + struct pm8921 *pmic) > +{ > + return 0; > +}
This looks suspicious.
> +static int __init pm8921_init(void) > +{ > + return platform_driver_register(&pm8921_driver); > +} > +postcore_initcall(pm8921_init);
Typically subsys_initcall() has been used.
| |