Messages in this thread | | | Date | Wed, 2 Mar 2011 21:56:37 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH v8 1/1] PRUSS UIO driver support |
| |
On Wed, 2 Mar 2011, Arnd Bergmann wrote:
> On Wednesday 02 March 2011 21:09:56 Hans J. Koch wrote: > > > +static struct uio_info *info; > > > +static dma_addr_t sram_paddr, ddr_paddr; > > > +static void *prussio_vaddr, *sram_vaddr, *ddr_vaddr; > > > > So the correct thing would be > > > > static void __iomem *prussio_vaddr; > > static void *sram_vaddr, *ddr_vaddr; > > I also commented that it should not be a global variable at > all, but a dynamic data structure referenced from the device. > > Not important, but Pratheesh said he'd change it. If it stays > a global variable, I'd at least expect an explanation why > the static variable is considered better in this case.
I did not pick at that, because there is no indicator that we'll see more than one PRUSS unit per SoC in the forseeable future.
Thanks,
tglx
| |