Messages in this thread | | | From | Linus Torvalds <> | Date | Wed, 2 Mar 2011 10:00:23 -0800 | Subject | Re: [PATCH v3 0/4] exec: unify native/compat code |
| |
On Wed, Mar 2, 2011 at 8:44 AM, Oleg Nesterov <oleg@redhat.com> wrote: > > forgot to mention... > > And probably you meant we should pass "struct conditional_ptr*", not > by value. I can redo again.
No, I think we're ok with passing the structure by value - it's a small structure that would generally be passed in registers (at least on some architectures, I guess it will depend on the ABI), and we do the "struct-by-value" thing for other things too (notably the page table entries), so it's not a new thing in the kernel.
So I think I finally have no complaints. Of course, I didn't actually check whether it _works_, but I assume it does.
If the s390 people (who actually do special things with compat pointers) can test, that would be ok, but I'm certainly happily going to apply this series when the next merge window opens.
Linus
| |