lkml.org 
[lkml]   [2011]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v8 1/1] PRUSS UIO driver support
    Date
    On Wednesday 02 March 2011, Pratheesh Gangadhar wrote:
    > +
    > +static struct clk *pruss_clk;
    > +static struct uio_info *info;
    > +static dma_addr_t sram_paddr, ddr_paddr;
    > +static void *prussio_vaddr, *sram_vaddr, *ddr_vaddr;
    > +

    To my initial comment about these being single-instance
    variables, you said you'd change that, which has not happened
    yet.

    Also, I now noticed that the types are wrong, you are
    missing __iomem annotations for MMIO ranges. Please make
    sure that the code builds fine with sparse and "make C=1",
    which will tell you about these problems.

    Arnd


    \
     
     \ /
      Last update: 2011-03-02 14:25    [W:0.018 / U:39.548 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site