Messages in this thread |  | | | From | Arnd Bergmann <> | | Subject | Re: [PATCH v8 1/1] PRUSS UIO driver support | | Date | Wed, 2 Mar 2011 14:22:26 +0100 |
| |
On Wednesday 02 March 2011, Pratheesh Gangadhar wrote: > + > +static struct clk *pruss_clk; > +static struct uio_info *info; > +static dma_addr_t sram_paddr, ddr_paddr; > +static void *prussio_vaddr, *sram_vaddr, *ddr_vaddr; > +
To my initial comment about these being single-instance variables, you said you'd change that, which has not happened yet.
Also, I now noticed that the types are wrong, you are missing __iomem annotations for MMIO ranges. Please make sure that the code builds fine with sparse and "make C=1", which will tell you about these problems.
Arnd
|  |