Messages in this thread | | | Date | Sat, 19 Mar 2011 19:59:05 +0100 | From | Piotr Hosowicz <> | Subject | Re: [PATCH] r8169: fix a bug in rtl8169_init_phy() |
| |
On 19.03.2011 16:39, Eric Dumazet wrote: > Le samedi 19 mars 2011 à 16:33 +0100, Eric Dumazet a écrit : >> Le samedi 19 mars 2011 à 16:31 +0100, Oliver Neukum a écrit : >>> Am Samstag, 19. März 2011, 16:18:50 schrieb Eric Dumazet: >>> >>>> Problem comes from commit 54405cde762408b00a445466a40da4f7f33a8479 >>>> (r8169: support control of advertising.) >>>> >>>> Reverting it brings back NIC for me >>> >>> Odd. It worked for me. Are you testing on a gigabit switch? Could you send >>> me dmesg? Does it work if you use ethtool to advertise a lower speed? >>> >>> Regards >>> Oliver >> >> I found the bug, I am sending a patch in two minutes. >> > > Here it is > > [PATCH] r8169: fix a bug in rtl8169_init_phy() > > commit 54405cde7624 (r8169: support control of advertising.) > introduced a bug in rtl8169_init_phy() > > Reported-by: Piotr Hosowicz<piotr@hosowicz.com> > Signed-off-by: Eric Dumazet<eric.dumazet@gmail.com> > Cc: Oliver Neukum<oliver@neukum.org> > Cc: Francois Romieu<romieu@fr.zoreil.com>
Tested-by: Piotr Hosowicz<piotr@hosowicz.com>
Works OK now.
Regards,
Piotr Hosowicz
-- Parafrazując Einsteina: w socjaliźmie są dwa zawody z przy- szłością: piekarz i urzędnik, chociaż co do pierwszego to nie mam pewności. (by Kubarek, http://blog.kubarek.info/) NP: Karmakanic - Send a message from the heart NB: 2.6.38-20110319-1638-net++ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |