Messages in this thread | | | Subject | Re: [PATCH 1/2 v2] WARN_ON_SMP(): Allow use in if statements on UP | From | Peter Zijlstra <> | Date | Fri, 18 Mar 2011 13:27:29 +0100 |
| |
On Fri, 2011-03-18 at 08:14 -0400, Steven Rostedt wrote: > On Fri, 2011-03-18 at 10:12 +0100, Peter Zijlstra wrote: > > On Thu, 2011-03-17 at 17:56 -0400, Steven Rostedt wrote: > > > + * WARN_ON(!spin_is_locked(&lock)) checks, as spin_is_locked() > > > + * returns 0 for uniprocessor settings. > > > > Arguably most spin_is_locked() usages should be removed in favour of > > something like lockdep_assert_held(). > > > > The latter only emits code then built with lockdep enabled and it checks > > we are indeed the owner, not some random other cpu. > > > > Perhaps we should have lockdep_assert_held() also be in > "spin_is_locked()".
Can't since its got stronger requirements.
| |