lkml.org 
[lkml]   [2011]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCHv3 3/3] ARM: mx51: Add support for low power suspend on MX51
    Date
    Sascha Hauer <s.hauer@pengutronix.de> writes:

    Hi,

    > On Wed, Mar 16, 2011 at 03:03:07PM -0500, Dinh.Nguyen@freescale.com wrote:
    >> +
    >> +struct clk *gpc_dvfs_clk;
    >> +
    >> +static int mx5_suspend_enter(suspend_state_t state)
    >> +{
    >> + if (gpc_dvfs_clk == NULL)
    >> + gpc_dvfs_clk = clk_get(NULL, "gpc_dvfs_clk");
    >
    > clk_get can fail and NULL can be a valid clock.

    So, I guess one may want to fail here if one can't get the clock. The
    suspend will fail in hard to debug way if this clock is not enabled
    at this point.

    Arnaud


    \
     
     \ /
      Last update: 2011-03-17 09:31    [W:0.020 / U:63.936 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site