lkml.org 
[lkml]   [2011]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC-v3 07/12] iscsi-target: Add CHAP Authentication support using libcrypto
On Thu, 17 Mar 2011, Jesper Juhl wrote:

> On Thu, 17 Mar 2011, Nicholas A. Bellinger wrote:
>
> > From: Nicholas Bellinger <nab@linux-iscsi.org>
> >
>
> Minor nitpicks below.
>
>
...
>
> > +int chap_server_compute_md5(
> > + struct iscsi_conn *conn,
> > + struct iscsi_node_auth *auth,
> > + char *NR_in_ptr,
> > + char *NR_out_ptr,
> > + unsigned int *NR_out_len)
> > +{
> > + char *endptr;
> > + unsigned char id, digest[MD5_SIGNATURE_SIZE];
> > + unsigned char type, response[MD5_SIGNATURE_SIZE * 2 + 2];
> > + unsigned char identifier[10], *challenge, *challenge_binhex;
>
> If you changed the above line to
>
> unsigned char identifier[10], *challenge;
> unsigned char *challenge_binhex = 0;
>

Actually, to be pedantic, that should probably be

unsigned char *challenge_binhex = NULL;


--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.



\
 
 \ /
  Last update: 2011-03-18 00:09    [W:0.130 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site