lkml.org 
[lkml]   [2011]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Some fixes for pstore (Was Re: [git pull] mnt_devname queue)
    On Thu, Mar 17, 2011 at 03:48:13PM -0700, Tony Luck wrote:
    > On Thu, Mar 17, 2011 at 3:42 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
    > >> + ? ? memcpy(private->data, data, size);
    > >> + ? ? inode->i_size = private->size = size;
    > >>
    > >> ? ? ? inode->i_private = private;
    > >
    > > Better move that before d_add()
    >
    > Will do.
    >
    > > *blink*
    > > ? ? ? ?if (IS_ERR(root))
    > > ? ? ? ? ? ? ? ?return root;
    > > ? ? ? ?return root;
    > >
    > > ... or am I misreading the patch?
    >
    > Your patch reading skills are fine ... the code deserves more than a *blink*.
    > Will fix.

    Send the updated patch my way, please.


    \
     
     \ /
      Last update: 2011-03-17 23:59    [W:0.019 / U:31.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site