[lkml]   [2011]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 2/2] oprofile: Add __exit attibute to oprofile_arch_exit() functions
    On Thu, Mar 17, 2011 at 07:41, Robert Richter wrote:
    > On 16.03.11 16:15:49, Mike Frysinger wrote:
    >> On Wed, Mar 16, 2011 at 13:58, Robert Richter wrote:
    >> >  979048e oprofile: don't call arch exit code from init code on failure
    >> >
    >> > we may add __exit attibutes to oprofile_arch_exit() functions.
    >> i dont think this the way to go.  how about updating one place
    >> (include/linux/oprofile.h:oprofile_arch_exit) and making sure all arch
    >> files are including that header if they arent already ?  after all, if
    >> they arent including that header, the arch code could break without
    >> noticing.
    > do you mean we specify the __exit attribute in the function
    > declaration of the header file and make sure it is included
    > everythere? I was looking at current implementations in the kernel and
    > this is not common. Mostly the attributes are set in the function
    > definition.

    i think that's because for most functions, there is no matching
    prototype in common code. drivers themselves have no reason to create
    such prototypes.

    > So I was not sure if that would work. If so, may we skip
    > then the __exit attribute in the definition?
    > GCC doc states: "The keyword __attribute__ allows you to specify
    > special attributes when making a declaration."
    > but nothing about that happens if it is in the function definition and
    > this is different from the declaration.

    if the function prototype is seen in the same file as the function
    definition, attributes are carried over. if it isnt (because the
    oprofile header isnt being included), then the attribute will be
    ignored for the function definition.
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2011-03-17 20:19    [W:0.021 / U:12.156 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site