lkml.org 
[lkml]   [2011]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/2] [ARM] am200epd: fix resource leak in am200_init_gpio_regs error path
    Applied.

    On Mon, Mar 7, 2011 at 1:55 PM, Axel Lin <axel.lin@gmail.com> wrote:
    > If gpio_request fails when i > 0, gpios[0] is not freed in current
    > implementation.
    >
    > Signed-off-by: Axel Lin <axel.lin@gmail.com>
    > ---
    >  arch/arm/mach-pxa/am200epd.c |    4 ++--
    >  1 files changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/arch/arm/mach-pxa/am200epd.c b/arch/arm/mach-pxa/am200epd.c
    > index 3499fad..811d797 100644
    > --- a/arch/arm/mach-pxa/am200epd.c
    > +++ b/arch/arm/mach-pxa/am200epd.c
    > @@ -128,8 +128,8 @@ static int am200_init_gpio_regs(struct metronomefb_par *par)
    >        return 0;
    >
    >  err_req_gpio:
    > -       while (i > 0)
    > -               gpio_free(gpios[i--]);
    > +       while (--i >= 0)
    > +               gpio_free(gpios[i]);
    >
    >        return err;
    >  }
    > --
    > 1.7.2
    >
    >
    >
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-03-17 16:09    [W:0.021 / U:63.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site