Messages in this thread | | | Date | Wed, 16 Mar 2011 13:13:13 +0800 | From | Harry Wei <> | Subject | Re: [PATCH 3/6] Documentation: update header filename in CodingStyle |
| |
On Tue, Mar 15, 2011 at 04:11:52PM -0700, Randy Dunlap wrote: > From: Roland Kammerer <dev.rck@gmail.com> > > pr_info() and pr_debug() are in linux/printk.h, not linux/kernel.h. > Last updated is unnecessary, we have git for that. > > Signed-off-by: Roland Kammerer <dev.rck@gmail.com> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Acked-by: Harry Wei <harryxiyou@gmail.com> > --- > Documentation/CodingStyle | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > --- lnx-2638-rc8.orig/Documentation/CodingStyle > +++ lnx-2638-rc8/Documentation/CodingStyle > @@ -659,7 +659,7 @@ There are a number of driver model diagn > which you should use to make sure messages are matched to the right device > and driver, and are tagged with the right level: dev_err(), dev_warn(), > dev_info(), and so forth. For messages that aren't associated with a > -particular device, <linux/kernel.h> defines pr_debug() and pr_info(). > +particular device, <linux/printk.h> defines pr_debug() and pr_info(). > > Coming up with good debugging messages can be quite a challenge; and once > you have them, they can be a huge help for remote troubleshooting. Such > @@ -819,6 +819,3 @@ language C, URL: http://www.open-std.org > Kernel CodingStyle, by greg@kroah.com at OLS 2002: > http://www.kroah.com/linux/talks/ols_2002_kernel_codingstyle_talk/html/ > > --- > -Last updated on 2007-July-13. > - > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
| |