lkml.org 
[lkml]   [2011]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] scsi: use list_move() instead of list_del()/list_add() combination
From
Date
On Tue, 2011-03-15 at 16:57 -0700, Robert Love wrote:
> From: Kirill A. Shutemov <kirill@shutemov.name>
>
> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> Cc: "James E.J. Bottomley" <James.Bottomley@suse.de>
> Cc: Robert Love <robert.w.love@intel.com>
> Cc: linux-scsi@vger.kernel.org
> Cc: devel@open-fcoe.org

You can junk the cc's; they're mostly annotations for git-send-email

> Acked-by: Robert Love <robert.w.love@intel.com>

And this has to be Signed-off-by not Acked-by. The reason is that
you've resent the patch (and altered it as you transmitted it) so that
makes you part of the signoff chain. If you ack a patch, it means I can
pick it up from source and you as maintainer didn't actually touch it.

James




\
 
 \ /
  Last update: 2011-03-16 02:55    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site