| Subject | Re: [RFC-v2 06/12] iscsi-target: Add iSCSI Login Negotiation and Parameter logic | From | "Nicholas A. Bellinger" <> | Date | Tue, 15 Mar 2011 15:55:19 -0700 |
| |
On Tue, 2011-03-15 at 11:21 +0100, Christoph Hellwig wrote: > The thread pool in iscsi_thread_queue.c looks like it really should > go away in favour of the new concurrency managed workqueues.
Yes, this code has been around for some time..
> Did you look into the current kernel kernel/workqueue.c code? >
I was thinking more about this for target core v4.1 / .40 stuff, but have not looked at this for iSCSI target not just yet..
I think this would be a good fit for immediate and response queues in iscsi_target_tx_thread(), and I think we could convert with fairly minimal breakage to the existing code if I understand Tejun's new model correct. I need to read-up a bit more before jumping on this conversion, but if you want to do an initial conversion I would be happy to merge it and help with the polish while I address your other comments.
--nab
|