lkml.org 
[lkml]   [2011]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 09/13] audit: use list_move() instead of list_del()/list_add() combination
    Date
    Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Cc: Eric Paris <eparis@redhat.com>
    ---
    kernel/audit_tree.c | 15 +++++----------
    1 files changed, 5 insertions(+), 10 deletions(-)

    diff --git a/kernel/audit_tree.c b/kernel/audit_tree.c
    index 37b2bea..6fe56d2 100644
    --- a/kernel/audit_tree.c
    +++ b/kernel/audit_tree.c
    @@ -591,8 +591,7 @@ void audit_trim_trees(void)

    tree = container_of(cursor.next, struct audit_tree, list);
    get_tree(tree);
    - list_del(&cursor);
    - list_add(&cursor, &tree->list);
    + list_move(&cursor, &tree->list);
    mutex_unlock(&audit_filter_mutex);

    err = kern_path(tree->pathname, 0, &path);
    @@ -744,8 +743,7 @@ int audit_tag_tree(char *old, char *new)

    tree = container_of(cursor.next, struct audit_tree, list);
    get_tree(tree);
    - list_del(&cursor);
    - list_add(&cursor, &tree->list);
    + list_move(&cursor, &tree->list);
    mutex_unlock(&audit_filter_mutex);

    err = kern_path(tree->pathname, 0, &path2);
    @@ -769,10 +767,8 @@ int audit_tag_tree(char *old, char *new)

    mutex_lock(&audit_filter_mutex);
    spin_lock(&hash_lock);
    - if (!tree->goner) {
    - list_del(&tree->list);
    - list_add(&tree->list, &tree_list);
    - }
    + if (!tree->goner)
    + list_move(&tree->list, &tree_list);
    spin_unlock(&hash_lock);
    put_tree(tree);
    }
    @@ -782,8 +778,7 @@ int audit_tag_tree(char *old, char *new)

    tree = container_of(barrier.prev, struct audit_tree, list);
    get_tree(tree);
    - list_del(&tree->list);
    - list_add(&tree->list, &barrier);
    + list_move(&tree->list, &barrier);
    mutex_unlock(&audit_filter_mutex);

    if (!failed) {
    --
    1.7.4.1


    \
     
     \ /
      Last update: 2011-03-15 23:57    [W:0.021 / U:59.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site