lkml.org 
[lkml]   [2011]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] perf: Fix tear-down of inherited group events
From
Date
On Tue, 2011-03-15 at 12:09 -0400, Vince Weaver wrote:
> On Tue, 15 Mar 2011, Peter Zijlstra wrote:
>
> > Subject: perf: Fix tear-down of inherited group events
> > From: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Date: Tue Mar 15 14:37:10 CET 2011
> >
> > When destroying inherited events, we need to destroy groups too,
> > otherwise the event iteration in perf_event_exit_task_context() will
> > miss group siblings and we leak events with all the consequences.
>
> Thanks for the fix! I can verify that when applied against current
> linus-git kernel that my original test case no longer leaks memory.
>
> I've also run the full PAPI regression tests, plus the BLAS/PAPI benchmark
> code that originally showed the problem and everything checks out fine.
>
> It's a shame this fix didn't make it in before 2.6.38.

It sure is, sadly there's still only 24h in a day, less if you consider
this .jp earthquake speeding up our planets spin :-)

> Tested-by: Vince Weaver <vweaver1@eecs.utk.edu>

Thanks Vince!


\
 
 \ /
  Last update: 2011-03-15 17:43    [W:0.055 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site