lkml.org 
[lkml]   [2011]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf: Fix tear-down of inherited group events
On Tue, 15 Mar 2011, Peter Zijlstra wrote:

> Subject: perf: Fix tear-down of inherited group events
> From: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Date: Tue Mar 15 14:37:10 CET 2011
>
> When destroying inherited events, we need to destroy groups too,
> otherwise the event iteration in perf_event_exit_task_context() will
> miss group siblings and we leak events with all the consequences.

Thanks for the fix! I can verify that when applied against current
linus-git kernel that my original test case no longer leaks memory.

I've also run the full PAPI regression tests, plus the BLAS/PAPI benchmark
code that originally showed the problem and everything checks out fine.

It's a shame this fix didn't make it in before 2.6.38.

Tested-by: Vince Weaver <vweaver1@eecs.utk.edu>

Vince
vweaver1@eecs.utk.edu


\
 
 \ /
  Last update: 2011-03-15 17:11    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site