lkml.org 
[lkml]   [2011]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2.6.38-rc8-tip 7/20] 7: uprobes: store/restore original instruction.
FromSteven Rostedt <>
DateTue, 15 Mar 2011 09:47:59 -0400
On Tue, 2011-03-15 at 14:52 +0530, Srikar Dronamraju wrote:
> * Stephen Wilson <wilsons@start.ca> [2011-03-14 14:09:14]:
>

Nitpick:

> Guess checking for tsk != NULL would only help if and only if we are doing
> within rcu. i.e we have to change to something like this
>

tsk = NULL;

> rcu_read_lock()
> if (mm->owner) {
> get_task_struct(mm->owner)
> tsk = mm->owner;
> }
> rcu_read_unlock()
> if (!tsk)
> return ret;
>
> Agree?

Or:

rcu_read_lock();
tsk = mm->owner;
if (tsk)
get_task_struct(tsk);
rcu_read_unlock();
if (!tsk)
return ret;
Probably looks cleaner.

-- Steve




\
 
 \ /
  Last update: 2011-03-15 14:51    [from the cache]
©2003-2010