lkml.org 
[lkml]   [2011]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]early: Fix possible overlapping data buffer
On Fri, Mar 11, 2011 at 11:04:42AM -0500, chenliu@asset.uwaterloo.ca wrote:
> Thanks Heiko. I've followed your advice to give a new patch here.
> ---------------------------------
>
> This patch fixed bugzilla #12965:
> https://bugzilla.kernel.org/show_bug.cgi?id=12965
>
> The original code contains some inproper use of sprintf
> function where a buffer is used both as input string
> as well as output string. It should remember the written
> bytes in the previous and use that as the offset for
> later writing. Also replace sprintf with snprintf.
>
> Signed-off-by: Chen Liu <chenliunju@gmail.com>

Hi Chen,

I still want a patch where the From: and Signed-off-by: lines
are identical. Otherwise I won't take the patch.

Also you didn't answer my other question: did you actually
test that after your change the code still works?
If not, then I would have to do that.

The patch looks ok so far (besides two lines that could
be removed).

Thanks,
Heiko


\
 
 \ /
  Last update: 2011-03-14 11:05    [W:0.044 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site