lkml.org 
[lkml]   [2011]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC-v2 12/12] iscsi-target: Add Makefile/Kconfig and update TCM top level
    On Mon, 14 Mar 2011, Nicholas A. Bellinger wrote:

    > From: Nicholas Bellinger <nab@linux-iscsi.org>
    >
    [...]
    > diff --git a/drivers/target/Makefile b/drivers/target/Makefile
    > index 60028fe..b038b7d 100644
    > --- a/drivers/target/Makefile
    > +++ b/drivers/target/Makefile
    > @@ -24,3 +24,4 @@ obj-$(CONFIG_TCM_PSCSI) += target_core_pscsi.o
    >
    > # Fabric modules
    > obj-$(CONFIG_TCM_LOOP_FABRIC) += tcm_loop/
    > +obj-$(CONFIG_ISCSI_TARGET) += iscsi/
    > diff --git a/drivers/target/iscsi/Kconfig b/drivers/target/iscsi/Kconfig
    > new file mode 100644
    > index 0000000..cc34243
    > --- /dev/null
    > +++ b/drivers/target/iscsi/Kconfig
    > @@ -0,0 +1,17 @@
    > +config ISCSI_TARGET
    > + tristate "Linux-iSCSI.org iSCSI Target Mode Stack"
    > + select CRYPTO
    > + select CRYPTO_CRC32C
    > + select CRYPTO_CRC32C_INTEL if X86
    > + help
    > + Say Y here to enable the ConfigFS enabled Linux-iSCSI.org iSCSI
    > + Target Mode Stack.
    > +
    > +if ISCSI_TARGET
    > +
    > +config ISCSI_TARGET_DEBUG
    > + bool "LIO-Target iscsi_debug.h ring buffer messages"
    > + help
    > + Say Y here to enable the legacy DEBUG_ISCSI macros in iscsi_debug.h
    > +
    > +endif
    [...]

    Perhaps this is a stupid question, but if these are "legacy" macros, why
    not save our users from having to deal with a new config option that is
    presumably going to go away again soon-ish and instead make those legacy
    macros go away sooner rather than later?

    --
    Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
    Plain text mails only, please.
    Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html



    \
     
     \ /
      Last update: 2011-03-15 02:07    [W:0.022 / U:59.464 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site