Messages in this thread |  | | | Date | Mon, 14 Mar 2011 13:10:49 +0100 (CET) | | From | Jiri Kosina <> | | Subject | Re: [PATCH 2/2] hid-ntrig: init settle and mode check |
| |
On Fri, 11 Mar 2011, Peter Hutterer wrote:
> > Adding a wait before the wakeup signal. > > > > As a precautionary measure sanity check the current sensor mode. If > > needed reset it to "dual". > > > > Signed-off-by: Rafi Rubin <rafi@seas.upenn.edu> > > > > When the device is responding poorly and needs the wakeup call, it was > > missing it. Giving it a chance to settle first improves the chances > > that signal gets through. > > > > I was also seeing the device come up in strange modes where it did not > > respond to physical stimulus. Hopefully the quirk will fix that, but > > even so it seems like a good idea to check. It also makes me curious > > what the "off" code is. > > --- > > drivers/hid/hid-ntrig.c | 45 +++++++++++++++++++++++++++++++++++++++++++-- > > 1 files changed, 43 insertions(+), 2 deletions(-) > > no negative effects > > Tested-by: Peter Hutterer <peter.hutterer@who-t.net>
Applied, thanks.
-- Jiri Kosina SUSE Labs, Novell Inc.
|  |