Messages in this thread | | | Date | Sun, 13 Mar 2011 03:28:03 -0500 | From | Mike Christie <> | Subject | Re: [PATCH 19/20] scsi: iscsi: world-writable sysfs priv_sess file |
| |
On 02/04/2011 06:24 AM, Vasiliy Kulikov wrote: > Don't allow everybody to change iSCSI settings. > > Signed-off-by: Vasiliy Kulikov<segoon@openwall.com> > --- > Compile tested only. > > drivers/scsi/scsi_transport_iscsi.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c > index f905ecb..01543d2 100644 > --- a/drivers/scsi/scsi_transport_iscsi.c > +++ b/drivers/scsi/scsi_transport_iscsi.c > @@ -1847,7 +1847,7 @@ store_priv_session_##field(struct device *dev, \ > #define iscsi_priv_session_rw_attr(field, format) \ > iscsi_priv_session_attr_show(field, format) \ > iscsi_priv_session_attr_store(field) \ > -static ISCSI_CLASS_ATTR(priv_sess, field, S_IRUGO | S_IWUGO, \ > +static ISCSI_CLASS_ATTR(priv_sess, field, S_IRUGO | S_IWUSR, \ > show_priv_session_##field, \ > store_priv_session_##field) > iscsi_priv_session_rw_attr(recovery_tmo, "%d");
Sorry for the late reply. Messed up on my side. Patch is correct and ok with me. Tested here.
Acked-by: Mike Christie <michaelc@cs.wisc.edu>
| |