Messages in this thread | | | Date | Sat, 12 Mar 2011 22:45:07 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH] input: set the long press detection in 88pm860x onkey |
| |
On Mon, Mar 07, 2011 at 11:43:18PM +0800, Haojian Zhuang wrote: > Move the long-press detection from onkey handler to probe function. Avoid > unnecessary I2C operation in onkey handler. > > Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell.com>
Acked-by: Dmitry Torokhov <dtor@mail.ru>
> --- > drivers/input/misc/88pm860x_onkey.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/input/misc/88pm860x_onkey.c b/drivers/input/misc/88pm860x_onkey.c > index 3dca3c1..1abc77e 100644 > --- a/drivers/input/misc/88pm860x_onkey.c > +++ b/drivers/input/misc/88pm860x_onkey.c > @@ -50,9 +50,6 @@ static irqreturn_t pm860x_onkey_handler(int irq, void *data) > ret &= ONKEY_STATUS; > input_report_key(info->idev, KEY_POWER, ret); > input_sync(info->idev); > - > - /* Enable 8-second long onkey detection */ > - pm860x_set_bits(info->i2c, PM8607_WAKEUP, 3, LONG_ONKEY_EN); > return IRQ_HANDLED; > } > > @@ -105,6 +102,9 @@ static int __devinit pm860x_onkey_probe(struct platform_device *pdev) > } > > platform_set_drvdata(pdev, info); > + > + /* Enable 8-second long onkey detection */ > + pm860x_set_bits(info->i2c, PM8607_WAKEUP, 3, LONG_ONKEY_EN); > return 0; > > out_irq: > -- > 1.5.6.5 >
-- Dmitry
| |