lkml.org 
[lkml]   [2011]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [x86 this_cpu_has V1 2/4] x86: Avoid passing struct cpuinfo pointer to mce_available
On Fri, Mar 11, 2011 at 10:23:12AM -0600, Christoph Lameter wrote:
> If we do not pass the pointer to cpuinfio to mce available then its possible
> to use this_cpu_has.
>
> There are two use cases of mce_available: One with the current processor
> and one with the boot cpu. Define a function for both cases. However, there
> is only one case in which boot_mce_available is used. If we somehow can
> get rid of that then the patch could be simplified.
>
> Signed-off-by: Christoph Lameter <cl@linux.com>

Christoph, I'm not sure about this one. None of the conversions is in
hot path, which would be okay if the resulting code was simpler but,
well, it isn't necessarily worse but not distinctively better either,
so I fail to see the merits of this conversion. I'll resend the other
three towards x86 tree.

Thank you.

--
tejun


\
 
 \ /
  Last update: 2011-03-12 12:43    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site