lkml.org 
[lkml]   [2011]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/2] jump label: update for .39
From
Date
On Fri, 2011-03-11 at 00:32 +0100, Thomas Gleixner wrote:

> > It should work, but it hurts my eyes to see the source code forcing a 64-bit
> > word to 32-bit alignment.
>
> We solved such stuff with macros in other places already.
>
> #ifdef 64bit
> # define BLA 8
> #else
> # define BLA 4
> #endif
>
> and then use
>
> .aling BLA
>
> Where is the problem?

That's basically the solution that Jason came up with, and what I
expected. What caught my eye was that David Miller had .align 4 for this
on sparc which is the one arch that is truly picky about such things. As
I understood more about this, I see that would work for both archs.

That doesn't mean I'm against the .align BLA solution.

-- Steve




\
 
 \ /
  Last update: 2011-03-11 00:45    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site