lkml.org 
[lkml]   [2011]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCHv3 0/1] sysfs: add more info to the oops dump
Date

> But would the trace-back also have shown you the problem? If not, then
> that's a good reason to keep this feature, and to add your patch.

In this sample size of one, the write handler was so overloaded
the data written was very valuable compared to the backtrace.

> Looks nicer, but you forgot to address the "magic value" trick you used
> that I mentioned last time. Please fix that up.

My bad, sorry. I also realised that I'd never actually tested the read
case, which highlighted a mixed-sign comparison issue. In a linux-2.6
context this hasn't been more than compile tested, my testing has been
done in our maemo tree.

cat /sys/module/vt/parameters/default_utf8; echo c > /proc/sysrq-trigger
[ 13.489440] last sysfs file (r): /sys/module/vt/parameters/default_utf8

echo sesquipedalian > /sys/module/vt/parameters/default_utf8; echo c > /proc/sysrq-trigger
[ 49.404632] last sysfs file (w): /sys/module/vt/parameters/default_utf8 written: sesquipedalian

echo sesquipedalianism > /sys/module/vt/parameters/default_utf8; echo c > /proc/sysrq-trigger
[ 33.172332] last sysfs file (w): /sys/module/vt/parameters/default_utf8 written: sesquipedaliani...(18 chars)

Sorry for the ping-pong.

Cheers,
Phil


\
 
 \ /
  Last update: 2011-03-10 23:35    [W:0.058 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site