Messages in this thread | | | From | Phil Carmody <> | Subject | [PATCHv3 0/1] sysfs: add more info to the oops dump | Date | Fri, 11 Mar 2011 00:27:06 +0200 |
| |
> But would the trace-back also have shown you the problem? If not, then > that's a good reason to keep this feature, and to add your patch.
In this sample size of one, the write handler was so overloaded the data written was very valuable compared to the backtrace.
> Looks nicer, but you forgot to address the "magic value" trick you used > that I mentioned last time. Please fix that up.
My bad, sorry. I also realised that I'd never actually tested the read case, which highlighted a mixed-sign comparison issue. In a linux-2.6 context this hasn't been more than compile tested, my testing has been done in our maemo tree.
cat /sys/module/vt/parameters/default_utf8; echo c > /proc/sysrq-trigger [ 13.489440] last sysfs file (r): /sys/module/vt/parameters/default_utf8
echo sesquipedalian > /sys/module/vt/parameters/default_utf8; echo c > /proc/sysrq-trigger [ 49.404632] last sysfs file (w): /sys/module/vt/parameters/default_utf8 written: sesquipedalian
echo sesquipedalianism > /sys/module/vt/parameters/default_utf8; echo c > /proc/sysrq-trigger [ 33.172332] last sysfs file (w): /sys/module/vt/parameters/default_utf8 written: sesquipedaliani...(18 chars)
Sorry for the ping-pong.
Cheers, Phil
| |