lkml.org 
[lkml]   [2011]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRE: [RFC v2 1/2] dynamic debug: add dynamic_hexdump_debug macro
    Hi Joe,

    > -----Original Message-----
    > From: Joe Perches [mailto:joe@perches.com]
    > Sent: Monday, February 28, 2011 9:26 PM
    > To: Bing Zhao
    > Cc: linux-kernel@vger.kernel.org; linux-wireless@vger.kernel.org; John W. Linville; Johannes Berg;
    > Amitkumar Karwar; Kiran Divekar; Frank Huang
    > Subject: Re: [RFC v2 1/2] dynamic debug: add dynamic_hexdump_debug macro
    >
    > On Mon, 2011-02-28 at 21:06 -0800, Bing Zhao wrote:
    > > dynamic_hexdump_debug(str, buf, len)
    >
    > > diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
    > > +#define dynamic_hexdump_debug(str, buf, len) \
    > > +do { \
    > > + static struct _ddebug descriptor \
    > > + __used \
    > > + __attribute__((section("__verbose"), aligned(8))) = \
    > > + { KBUILD_MODNAME, __func__, __FILE__, str, __LINE__, \
    > > + _DPRINTK_FLAGS_DEFAULT }; \
    > > + if (unlikely(descriptor.enabled)) { \
    > > + printk(KERN_DEBUG str); \
    > > + print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, buf, len); \
    >
    > Perhaps
    > print_hex_dump(str, DUMP_PREFIX_OFFSET, buf, len);

    I wanted to print the "str" as a subject line, like this:

    mwifiex data: tx_buf:
    00000000: 34 8c 24 a0 ff ff ff ff 36 72 24 a0 ff ff ff ff 4.$.....6r$.....
    00000010: d7 7f 24 a0 ff ff ff ff 80 8e 24 a0 ff ff ff ff ..$.......$.....
    00000020: df 7d 24 a0 ff ff .}$...

    The "str" will serve as the prefix strings if we use
    print_hex_dump(KERN_DEBUG, str, DUMP_PREFIX_OFFSET, 16, 1, buf, len, true);

    mwifiex data: tx_buf:00000000: 34 8c 24 a0 ff ff ff ff 36 72 24 a0 ff ff ff ff 4.$.....6r$.....
    mwifiex data: tx_buf:00000010: d7 7f 24 a0 ff ff ff ff 80 8e 24 a0 ff ff ff ff ..$.......$.....
    mwifiex data: tx_buf:00000020: df 7d 24 a0 ff ff .}$...

    I'm okay with this format too.

    Thanks,

    Bing

    \
     
     \ /
      Last update: 2011-03-01 20:37    [W:0.038 / U:1.064 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site