lkml.org 
[lkml]   [2011]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/6 v6] vfs: export do_splice_direct() to modules
    From
    Miklos,

    On Tue, Mar 1, 2011 at 1:36 PM, Miklos Szeredi <miklos@szeredi.hu> wrote:
    > From: Miklos Szeredi <mszeredi@suse.cz>
    >
    > Export do_splice_direct() to modules.  Needed by overlay filesystem.
    >
    > Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
    > ---
    >  fs/splice.c |    1 +
    >  1 file changed, 1 insertion(+)
    >
    > Index: linux-2.6/fs/splice.c
    > ===================================================================
    > --- linux-2.6.orig/fs/splice.c  2011-02-22 11:04:39.000000000 +0100
    > +++ linux-2.6/fs/splice.c       2011-03-01 12:18:16.000000000 +0100
    > @@ -1296,6 +1296,7 @@ long do_splice_direct(struct file *in, l
    >
    >        return ret;
    >  }
    > +EXPORT_SYMBOL(do_splice_direct);

    I have a question on your patch, why are you using EXPORT_SYMBOL()
    instead of EXPORT_SYMBOL_GPL()?
    Are you using EXPORT_SYMBOL() because all symbols in fs/splice.c
    are exported via EXPORT_SYMBOL()?

    To be more precise, are there any rules to decide when _GPL() should be used?
    IMHO we should always use _GPL() for new symbols.

    >  static int splice_pipe_to_pipe(struct pipe_inode_info *ipipe,
    >                               struct pipe_inode_info *opipe,
    >
    > --
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at  http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at  http://www.tux.org/lkml/
    >

    --
    Thanks,
    //richard
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-03-01 16:51    [W:0.024 / U:29.832 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site