lkml.org 
[lkml]   [2011]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] hwmon: Consider LM64 temperature offset
    Hi Dirk,

    On Wed, Feb 09, 2011 at 04:51:34AM -0500, Dirk Eibach wrote:
    [ ... ]
    > +/* temp2_crit can only be set once which should be job of the bootloader */
    > +static SENSOR_DEVICE_ATTR(temp2_crit, S_IRUGO, show_remote_temp8,
    > + NULL, 2);

    That only applies to lm63, though. It can be rewritten anytime on LM64.
    That would be a separate patch, though, to not mix improvements with bug fixes.

    Otherwise, looks good, so I'll apply it with an added remark that the restriction
    only applies to lm63.

    Thanks,
    Guenter


    \
     
     \ /
      Last update: 2011-02-09 19:21    [W:0.019 / U:32.676 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site