lkml.org 
[lkml]   [2011]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC] staging: olpc_dcon: Remove _strtoul() function.
On Tue, Feb 08, 2011 at 12:06:00PM +0100, Marek Belisko wrote:
> olpc_dcon driver use self invented _strtoul function
> which make similar check like strict_strtoul just extend
> for space checking at last string place. Normally access
> to sys file looks echo 1024 > /sys/... so space could be considered
> as error character and we could simplify code using just strict_strtoul
> function instead self invented.
>

Could you do it on top of the patches that Andres Salomon sent?

http://driverdev.linuxdriverproject.org/pipermail/devel/2011-February/thread.html

# [PATCH 1/4] olpc_dcon: get rid of global i2c_client, create a dcon_priv struct Andres Salomon
# [PATCH 2/4] olpc_dcon: change sysfs 'output' toggle to be clearer... Andres Salomon
# [PATCH 3/4] olpc_dcon: move more variables into dcon_priv Andres Salomon
# [PATCH 4/4] olpc_dcon: actually return the value of i2c_add_driver Andres Salomon

regards,
dan carpenter




\
 
 \ /
  Last update: 2011-02-08 12:27    [W:0.090 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site