lkml.org 
[lkml]   [2011]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tpm_tis: Use timeouts returned from TPM
On 02/08/2011 07:45 PM, Guillaume Chazarain wrote:
> [ + jmorris ]
>
> On Thu, Jan 27, 2011 at 11:44 PM, Guillaume Chazarain<guichaz@gmail.com> wrote:
>> On Tue, Jan 11, 2011 at 8:37 PM, Stefan Berger
>> <stefanb@linux.vnet.ibm.com> wrote:
>>> The current TPM TIS driver in git discards the timeout values returned
>>> from the TPM.
>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c4ff4b829ef9e6353c0b133b7adb564a68054979
>> broke the TPM for me on a thinkpad T410. When using the TPM, dmesg
>> complains:
>>
>> [ 65.728310] tpm_tis 00:0b: Operation Timed out
>> [ 67.651450] tpm_tis 00:0b: Operation Timed out
>> [ 69.669421] tpm_tis 00:0b: Operation Timed out
>>
>> This patch fixes it, so consider it:
>>
>> Tested-by: Guillaume Chazarain<guichaz@gmail.com>
> This patch (https://lkml.org/lkml/2011/1/11/341) fixes a regression
> introduced in 2.6.38-rc3, any chance of having it merged?
>
> Thanks.

This patch solves a bug existent before the commit that made into
2.6.38-rc3. Prior to such commit, the device driver was using default
values that were big enough to allow TPM commands to succeed, but that
stalled the kernel for too long during boot (2 minutes for each command
sent) when buggy TPMs don't respond.

I'll apply this patch to my tree, and ask James to pull from it.

Rajiv





\
 
 \ /
  Last update: 2011-02-08 23:11    [W:0.054 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site