lkml.org 
[lkml]   [2011]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 00/14] POWER: BQ27x00: New Properties, fixes, bq27000 support
    On Tue, Feb 08, 2011 at 05:13:47PM +0100, Lars-Peter Clausen wrote:
    > On 02/08/2011 12:40 PM, Grazvydas Ignotas wrote:
    > > That works. However I wonder about the delay, I've experimentally
    > > determined that bq27500 refreshes in about a second, so before this
    > > series I could for example run 'watch -n 1 cat current_now' and see
    > > current changes almost in realtime (when toggling backlight, for
    > > example). Maybe we could have different cache timeout for different
    > > chips or have quickly changing properties (like current and voltage)
    > > bypass the cache.
    >
    > Looking at the datasheet confirms that the bq27500 updates the current register
    > every second. The bq27000 updates it only every 5.12 seconds.
    > I think reducing the the cache time for bq27500 to 1 second would render the
    > cache mostly useless, but maybe it makes sense to bypass the cache for voltage
    > and current on the bq27500.

    Nope, it's not useless. I.e. for `cat /sys/class/power_supply/*/*`.
    Actually, it was only the purpose for caching the battery values.

    So, 1 second is OK.

    p.s. Lars, on the next resend, can you please remove "POWER:"
    prefix from the patch description line, bound the commit message
    width to 76 symbols, and add all the collected Acked-by lines.
    That way I can just pull your tree.

    Thanks!

    --
    Anton Vorontsov
    Email: cbouatmailru@gmail.com


    \
     
     \ /
      Last update: 2011-02-08 17:31    [W:0.020 / U:31.512 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site