Messages in this thread | | | From | "Tomoya MORINAGA" <> | Subject | RE: About bittiming calculation result | Date | Tue, 8 Feb 2011 10:09:48 +0900 |
| |
On Monday, February 07, 2011 9:01 PM, Wolfgang Grandegger wrote > > Well, only prop_seg+phase_seg=tseg1 is relevant and the > pch_can driver sets the allowed minimum "tseg1_min1" currently to 1: > > static struct can_bittiming_const pch_can_bittiming_const = { > .name = KBUILD_MODNAME, > .tseg1_min = 1, > .tseg1_max = 16, > .tseg2_min = 1, > .tseg2_max = 8, > .sjw_max = 4, > .brp_min = 1, > .brp_max = 1024, /* 6bit + extended 4bit */ > .brp_inc = 1, > }; > > > seg1/seg2/sjw/prop_seg must be more than 1 ? > > Then "tseg1_min" should be set to *2*.
Though some drivers accepted by upstream have parameter "tseg1_min" as 1, Sould we release the patch like below ? - .tseg1_min = 1, + .tseg1_min = 2,
Thanks, ----------------------------------------- Tomoya MORINAGA OKI SEMICONDUCTOR CO., LTD.
| |