Messages in this thread | | | Date | Mon, 7 Feb 2011 15:36:53 -0200 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 0/9] perf/core improvements and fixes |
| |
Em Mon, Feb 07, 2011 at 02:29:16PM -0200, Arnaldo Carvalho de Melo escreveu: > Em Mon, Feb 07, 2011 at 04:06:40PM +0100, Ingo Molnar escreveu: > > * Arnaldo Carvalho de Melo <acme@infradead.org> wrote: > > > Masami Hiramatsu (4): > > > perf probe: Add bitfield member support > > > > hm, the perf probe bits do not build on 32-bit: > > > > util/probe-finder.c: In function ‘convert_variable_type’: > > util/probe-finder.c:881: error: format ‘%lu’ expects type ‘long unsigned int’, but argument 6 has type ‘unsigned int’ > > util/probe-finder.c:881: error: format ‘%lu’ expects type ‘long unsigned int’, but argument 6 has type ‘unsigned int’ > > make: *** [util/probe-finder.o] Error 1 > > make: *** Waiting for unfinished jobs.... > > I already reworked this and force pushed, see: > > http://git.kernel.org/?p=linux/kernel/git/acme/linux-2.6.git;a=commitdiff;h=2b4f8985a2c2309852d20d16d3589eba15b64c4e > > [ committer note: Fixed up '%lu' use for return of die_get_byte_size (int) ]
Argh, I used '%d', which is ok on 32-bit, but then, breaks 64-bit, i.e. the right format is '%zd' since the expression is '... / sizeof(foo)', test built on both 64 and 32 bit, this time around it seems final.
Just give it some time to go from master to git.k.o.
- Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |