lkml.org 
[lkml]   [2011]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] olpc_dcon: move more variables into dcon_priv
On Sun, Feb 06, 2011 at 03:28:46PM -0800, Andres Salomon wrote:
> bool mono:1;
> + bool asleep:1;
^^

Not needed.

> - return sprintf(buf, "%d\n", dcon_sleep_val);
> + struct dcon_priv *dcon = dev_get_drvdata(dev);
> + return sprintf(buf, "%d\n", dcon->asleep ? 1 : 0);
^^^^^^^

Also not needed.

These are fussy things. Feel free to fix them in a later patch series.

regards,
dan carpenter



\
 
 \ /
  Last update: 2011-02-07 07:33    [W:0.033 / U:1.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site