[lkml]   [2011]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: x25: possible skb leak on bad facilities
    The issue is a bit more complex than Andy's patch, I think I have a full fix.
    Burning it in on test system now, if thats OK ill post patch in a few hours.

    On Mon, Feb 7, 2011 at 3:28 PM, David Miller <> wrote:
    > From: Andrew Hendry <>
    > Date: Tue, 1 Feb 2011 22:55:13 +1100
    >> There are two callers, when I was crashing it I don't remember it
    >> using the backlog path.
    >> x25_process_rx_frame is called from both x25_backlog_rcv and also
    >> x25_receive_data (via x25_lapb_receive_frame)
    >> But reviewing that second path now it looks like it will also leak, -1
    >> would make it skip the kfree_skb there as well.
    >> So patch looks good to me, when I have some time I'll run it through
    >> the environment I had setup originally to confirm.
    > Andrew, have you had a chance to do this yet?

     \ /
      Last update: 2011-02-07 07:31    [W:0.025 / U:5.740 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site