lkml.org 
[lkml]   [2011]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] memblock: Fix error path in memblock_add_region()
From
Date
2011-02-06 (일), 09:46 -0800, Yinghai Lu:
> we can skip the restoring.
>
> Thanks
>
> Yinghai
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index bdba245..3231657 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -374,13 +374,9 @@ static long __init_memblock memblock_add_region(struct memblock_type *type, phys
> }
> type->cnt++;
>
> - /* The array is full ? Try to resize it. If that fails, we undo
> - * our allocation and return an error
> - */
> - if (type->cnt == type->max && memblock_double_array(type)) {
> - type->cnt--;
> + /* The array is full ? Try to resize it */
> + if (type->cnt == type->max && memblock_double_array(type))
> return -1;
> - }
>
> return 0;
> }

Looks OK to me, too.
Thanks.


--
Regards,
Namhyung Kim


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-02-07 06:03    [W:0.032 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site