Messages in this thread | | | Date | Mon, 7 Feb 2011 12:48:58 +0800 | Subject | Re: Commit 500f7147cf5bafd139056d521536b10c2bc2e154 breaks _resume_ | From | Jeff Chua <> |
| |
On Sun, Feb 6, 2011 at 11:27 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote: > One last step: move contents of intel_crtc_reset() back to > intel_crtc_init() one by one. > > The active flag is my suspicion. I was thinking that we brought up the > outputs in a similar manner upon resume as upon initial boot. On > reflection, this is the not case. > > However, the first action we take inside modesetting is to disable the > outputs about to be reconfigured. So setting active should be the right > course of action so that cleanup any residual state from resume. > > So I am intrigued as to which line is the cause, and just where the > machine becomes unresponsive...
It's this line causing the problem.
intel_crtc->active = true; /* force the pipe off on setup_init_config */
When it's called before entering intel_crtc_reset(&intel_crtc->base), it works, but if called within the function, it doesn't work. Strange. Not sure whether is passing the correct value to to_intel_crtc(crtc)?
Jeff
| |