Messages in this thread Patch in this message | | | Date | Sat, 5 Feb 2011 10:39:18 +0000 | From | Denis Kirjanov <> | Subject | [PATCH 1/2] sysclt_check: drop table->procname checks |
| |
Sine the for loop checks for the table->procname drop useless table->procname checks inside the loop body
Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org> --- kernel/sysctl_check.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/kernel/sysctl_check.c b/kernel/sysctl_check.c index 10b90d8..3a01c3e 100644 --- a/kernel/sysctl_check.c +++ b/kernel/sysctl_check.c @@ -111,11 +111,9 @@ int sysctl_check_table(struct nsproxy *namespaces, struct ctl_table *table) const char *fail = NULL; if (table->parent) { - if (table->procname && !table->parent->procname) + if (!table->parent->procname) set_fail(&fail, table, "Parent without procname"); } - if (!table->procname) - set_fail(&fail, table, "No procname"); if (table->child) { if (table->data) set_fail(&fail, table, "Directory with data?"); @@ -144,7 +142,7 @@ int sysctl_check_table(struct nsproxy *namespaces, struct ctl_table *table) set_fail(&fail, table, "No maxlen"); } #ifdef CONFIG_PROC_SYSCTL - if (table->procname && !table->proc_handler) + if (!table->proc_handler) set_fail(&fail, table, "No proc_handler"); #endif #if 0 -- 1.7.3.4
| |