lkml.org 
[lkml]   [2011]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 03/20] mach-omap2: smartreflex: world-writable debugfs voltage files
Date
Vasiliy Kulikov <segoon@openwall.com> writes:

> Don't allow everybody to change voltage settings.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> ---
> Cannot compile the driver, so it is not tested at all.

Acked-by: Kevin Hilman <khilman@ti.com>


> arch/arm/mach-omap2/smartreflex.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
> index c37e823..95ac336 100644
> --- a/arch/arm/mach-omap2/smartreflex.c
> +++ b/arch/arm/mach-omap2/smartreflex.c
> @@ -900,7 +900,7 @@ static int __init omap_sr_probe(struct platform_device *pdev)
> return PTR_ERR(dbg_dir);
> }
>
> - (void) debugfs_create_file("autocomp", S_IRUGO | S_IWUGO, dbg_dir,
> + (void) debugfs_create_file("autocomp", S_IRUGO | S_IWUSR, dbg_dir,
> (void *)sr_info, &pm_sr_fops);
> (void) debugfs_create_x32("errweight", S_IRUGO, dbg_dir,
> &sr_info->err_weight);
> @@ -939,7 +939,7 @@ static int __init omap_sr_probe(struct platform_device *pdev)
> strcpy(name, "volt_");
> sprintf(volt_name, "%d", volt_data[i].volt_nominal);
> strcat(name, volt_name);
> - (void) debugfs_create_x32(name, S_IRUGO | S_IWUGO, nvalue_dir,
> + (void) debugfs_create_x32(name, S_IRUGO | S_IWUSR, nvalue_dir,
> &(sr_info->nvalue_table[i].nvalue));
> }


\
 
 \ /
  Last update: 2011-02-04 23:57    [W:0.093 / U:0.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site