Messages in this thread | | | Date | Fri, 4 Feb 2011 09:53:54 +0900 | From | Daisuke Nishimura <> | Subject | Re: [patch 3/5] memcg: fold __mem_cgroup_move_account into caller |
| |
On Fri, 4 Feb 2011 09:07:38 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> On Thu, 3 Feb 2011 15:26:04 +0100 > Johannes Weiner <hannes@cmpxchg.org> wrote: > > > It is one logical function, no need to have it split up. > > > > Also, get rid of some checks from the inner function that ensured the > > sanity of the outer function. > > > > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> > > I think there was a reason to split them...but it seems I forget it.. > IIRC, it's me who split them up in commit 57f9fd7d.
But the purpose of the commit was cleanup move_parent() and move_account() to use move_accout() in move_charge() later. So, there was no technical reason why I split move_account() and __move_account(). It was just because I liked to make each functions do one thing: check validness and actually move account.
Anyway, I don't have any objection to folding them. page_is_cgroup_locked() can be removed by this change.
Acked-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Thanks, Daisuke Nishimura.
| |