Messages in this thread | | | Date | Fri, 4 Feb 2011 09:01:45 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [patch 1/5] memcg: no uncharged pages reach page_cgroup_zoneinfo |
| |
On Thu, 3 Feb 2011 15:26:02 +0100 Johannes Weiner <hannes@cmpxchg.org> wrote:
> All callsites check PCG_USED before passing pc->mem_cgroup, so the > latter is never NULL. > > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
I want BUG_ON() here.
> --- > mm/memcontrol.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index e071d7e..85b4b5a 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -370,9 +370,6 @@ page_cgroup_zoneinfo(struct page_cgroup *pc) > int nid = page_cgroup_nid(pc); > int zid = page_cgroup_zid(pc); > > - if (!mem) > - return NULL; > - > return mem_cgroup_zoneinfo(mem, nid, zid); > } > > -- > 1.7.4 > >
| |