lkml.org 
[lkml]   [2011]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH v6 1/1] PRUSS UIO driver support
Hi,

> -----Original Message-----
> From: Hans J. Koch [mailto:hjk@hansjkoch.de]
> Sent: Tuesday, March 01, 2011 2:57 AM
> To: TK, Pratheesh Gangadhar
> Cc: linux-kernel@vger.kernel.org; hjk@hansjkoch.de; gregkh@suse.de;
> tglx@linutronix.de; sshtylyov@mvista.com; arnd@arndb.de; Chatterjee, Amit;
> davinci-linux-open-source@linux.davincidsp.com; linux-arm-
> kernel@lists.infradead.org
> Subject: Re: [PATCH v6 1/1] PRUSS UIO driver support
>
> On Tue, Mar 01, 2011 at 02:31:35AM +0530, Pratheesh Gangadhar wrote:
> > +
> > + /* Register PRUSS IRQ lines */
> > + p->irq = IRQ_DA8XX_EVTOUT0 + cnt;
> > + p->handler = pruss_handler;
> > +
> > + ret = uio_register_device(&dev->dev, p);
> > +
> > + if (ret < 0)
> > + goto out_free;
> > + }
> > +
> > + spin_lock_init(&lock);
>
> That's too late. uio_register_device() enables the irq, and your spin_lock
> is not ready at that time.

This is ok in this context as "modprobe uio_pruss" is pre-requisite for
running PRUSS firmware and without firmware running PRUSS won't
generate interrupts. Actually PRUSS INTC is not setup till we start
user application.

Thanks,
Pratheesh



\
 
 \ /
  Last update: 2011-03-01 05:49    [W:0.192 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site