Messages in this thread Patch in this message | | | Date | Mon, 28 Feb 2011 08:22:29 -0800 | From | Greg KH <> | Subject | [08/68] x25: decrement netdev reference counts on unload |
| |
2.6.32-longterm review patch. If anyone has any objections, please let us know.
------------------
From: Apollon Oikonomopoulos <apollon@noc.grnet.gr>
commit 171995e5d82dcc92bea37a7d2a2ecc21068a0f19 upstream.
x25 does not decrement the network device reference counts on module unload. Thus unregistering any pre-existing interface after unloading the x25 module hangs and results in
unregister_netdevice: waiting for tap0 to become free. Usage count = 1
This patch decrements the reference counts of all interfaces in x25_link_free, the way it is already done in x25_link_device_down for NETDEV_DOWN events.
Signed-off-by: Apollon Oikonomopoulos <apollon@noc.grnet.gr> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- net/x25/x25_link.c | 1 + 1 file changed, 1 insertion(+)
--- a/net/x25/x25_link.c +++ b/net/x25/x25_link.c @@ -393,6 +393,7 @@ void __exit x25_link_free(void) list_for_each_safe(entry, tmp, &x25_neigh_list) { nb = list_entry(entry, struct x25_neigh, node); __x25_remove_neigh(nb); + dev_put(nb->dev); } write_unlock_bh(&x25_neigh_list_lock); }
| |