Messages in this thread | | | Date | Tue, 1 Mar 2011 00:25:54 +0800 | From | Américo Wang <> | Subject | Re: [2.6.38-rc6] build:mkpiggy fixlet... |
| |
On Wed, Feb 23, 2011 at 09:33:59AM +0800, Daniel J Blueman wrote: >Ensure build doesn't silently continue despite read failure, >addressing a warning due to the unchecked call. > >Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com> > >diff --git a/arch/x86/boot/compressed/mkpiggy.c >b/arch/x86/boot/compressed/mkpiggy.c >index 646aa78..845a1f8 100644 >--- a/arch/x86/boot/compressed/mkpiggy.c >+++ b/arch/x86/boot/compressed/mkpiggy.c >@@ -62,7 +62,12 @@ int main(int argc, char *argv[]) > if (fseek(f, -4L, SEEK_END)) { > perror(argv[1]); > } >- fread(&olen, sizeof olen, 1, f); >+ >+ if (fread(&olen, sizeof(olen), 1, f) != 1) { >+ perror(argv[1]); >+ return 1;
You need to close the file here...
>+ } >+ > ilen = ftell(f); > olen = getle32(&olen); > fclose(f);
Thanks.
| |