lkml.org 
[lkml]   [2011]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 6/9] memcg: add kernel calls for memcg dirty page stats
On Mon, 28 Feb 2011 02:01:43 +0900
Minchan Kim <minchan.kim@gmail.com> wrote:

> On Fri, Feb 25, 2011 at 01:35:57PM -0800, Greg Thelen wrote:
spin_unlock_irqrestore(&mapping->tree_lock, flags);
> > } else {
> > @@ -1365,6 +1368,7 @@ int test_set_page_writeback(struct page *page)
> > PAGECACHE_TAG_WRITEBACK);
> > if (bdi_cap_account_writeback(bdi))
> > __inc_bdi_stat(bdi, BDI_WRITEBACK);
> > + mem_cgroup_inc_page_stat(page, MEMCG_NR_FILE_WRITEBACK);
>
> Question:
> Why should we care of BDI_CAP_NO_WRITEBACK?
>
Hmm, should we do ..
==
if (!ret) {
account_page_writeback(page);
+ mem_cgroup_inc_page_stat(page, MEMCG_NR_FILE_WRITEBACL);
}
==

Thanks,
-Kame



\
 
 \ /
  Last update: 2011-02-28 03:49    [W:1.421 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site