Messages in this thread | | | Date | Mon, 28 Feb 2011 11:40:18 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [PATCH v5 6/9] memcg: add kernel calls for memcg dirty page stats |
| |
On Mon, 28 Feb 2011 02:01:43 +0900 Minchan Kim <minchan.kim@gmail.com> wrote:
> On Fri, Feb 25, 2011 at 01:35:57PM -0800, Greg Thelen wrote: spin_unlock_irqrestore(&mapping->tree_lock, flags); > > } else { > > @@ -1365,6 +1368,7 @@ int test_set_page_writeback(struct page *page) > > PAGECACHE_TAG_WRITEBACK); > > if (bdi_cap_account_writeback(bdi)) > > __inc_bdi_stat(bdi, BDI_WRITEBACK); > > + mem_cgroup_inc_page_stat(page, MEMCG_NR_FILE_WRITEBACK); > > Question: > Why should we care of BDI_CAP_NO_WRITEBACK? > Hmm, should we do .. == if (!ret) { account_page_writeback(page); + mem_cgroup_inc_page_stat(page, MEMCG_NR_FILE_WRITEBACL); } ==
Thanks, -Kame
| |