Messages in this thread | | | Date | Fri, 25 Feb 2011 22:41:32 -0800 | From | Andres Salomon <> | Subject | Re: [PATCH v5] of/promtree: allow DT device matching by fixing 'name' brokenness |
| |
On Thu, 24 Feb 2011 23:06:06 -0700 Grant Likely <grant.likely@secretlab.ca> wrote:
> On Thu, Feb 24, 2011 at 1:01 PM, Andres Salomon <dilinger@queued.net> > wrote: > > On Thu, 24 Feb 2011 12:42:34 -0700 > > Grant Likely <grant.likely@secretlab.ca> wrote: > >> If firmware is buggy, then pkg2path must deal with it. It is not > >> okay for it to return NULL. (I know that pkg2path is an OFW > >> command, but in this context it really means the linux wrapper to > >> pkg2path which has the semantics, "give me the unique, full and > >> accurate path for this node"). If OFW pkg2path doesn't work, then > >> the platform code must work around it. I'm pushing back on this > >> because I do not want to see platform workarounds in the common > >> code. > > > > I'm fine with that, I just don't want to see BUG() happening that > > early. I think a workaround should be handled in common code. I > > agree that heroic workarounds for firmware bugs should be handled in > > arch-specific pkg2path hooks, but a simple workaround in common code > > is better than just crashing early in boot (imo). > > Alright, you've swayed me a bit. I've made this change and pushed it > out to devicetree/experimental. I've also picked up your other patch. > Let me know if it works for you.
Thanks, that looks good. Feel free to push into next.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |